Skip to content

Replace gas sprite animations with shader-based animations. #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

ruddygreat
Copy link

@ruddygreat ruddygreat commented Feb 3, 2025

A set of fairly small edits to GasTileOverlay, GasPrototype & gases.yml to allow them to use shaders instead of sprite animations.

Still not entirely happy with the effects but I could sit here tweaking numbers for a decade and probably not be happy with them.
They do have a semi-notable quirk of not showing up too well over specifically white tiles as a side-effect of how I wrote the shaders, though the actively dangerous gases are still very visible.

Screen.Recording.2025-02-10.180655.mp4

Changelog
🆑

  • tweak: Overhauled the look of every gas!
  • tweak: Changed what colours are used for each gas in the gas analyzer to more accurately reflect the gas's colour in-world.

@ruddygreat ruddygreat marked this pull request as ready for review February 10, 2025 18:33
@ruddygreat
Copy link
Author

Opening for review now that I've got everything more or less done, would appreciate if people w/ older hardware especially could test this out to make sure that it doesn't make things explode on you.

@mqole
Copy link
Member

mqole commented Feb 10, 2025

image
straight up not showing up for me.

@ruddygreat
Copy link
Author

interesting!
might be because none of the gases are in a high enough concentration to actually show up, I'll check that out

@ruddygreat
Copy link
Author

oh Something Is Going On Here, things change based on how zoomed in you are for no apparent reason....
marking as a draft again while I figure this out

@ruddygreat ruddygreat marked this pull request as draft February 11, 2025 15:29
@iaada
Copy link

iaada commented Feb 11, 2025

image straight up not showing up for me.

Does this maybe have something to do with how you can only have 1 shader at a time?

@ruddygreat
Copy link
Author

Nah, I think there's some deeper bug / quirk with the way the game renders things that just doesn't like the way I'm specifically doing this.
I may have to do a more comprehensive rewrite of the overlay to work better w/ what I'm doing, but for now this'll probably be dead in the water for a good while.

@mqole mqole added the PR limbo A PR that's waiting on other issues / dev stuff to get fixed before we merge label Feb 15, 2025
@ruddygreat ruddygreat closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR limbo A PR that's waiting on other issues / dev stuff to get fixed before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants